-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix backport for #3227 #3282
Fix backport for #3227 #3282
Conversation
This pull request is in conflict. Could you fix it @pac48? |
Please target the |
This pull request is in conflict. Could you fix it @pac48? |
6ba52b6
to
42b9ea2
Compare
Signed-off-by: Paul Gesel <[email protected]>
42b9ea2
to
14dbd17
Compare
Thanks @pac48! Seems the build is failing due to targets that don't exist on the humble branch. Might need to remove those. https://github.com/moveit/moveit2/actions/runs/13039259023/job/36377097965?pr=3282#step:11:301 |
Okay, I’ll take another look soon. The merge is definitely not trivia in this case due to all of the differences. |
I just gave this a try and think I got it building. Note to build locally I also cherry-picked #3296, which will be merged in first, so don't worry about the |
afac11d
into
moveit:mergify/bp/humble/pr-3227
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## mergify/bp/humble/pr-3227 #3282 +/- ##
=================================================
=================================================
☔ View full report in Codecov by Sentry. |
No description provided.