Update suncalc.js #125
Open
Update suncalc.js #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadir shifted from past to future!
|
@mourner would be great if we get this merged due to the fact, that nadir is not really usable when its calculated wrong. |
|
Could you add a function that calculates the day of moon? |
|
published a new version which include this as https://github.com/Hypnos3/suncalc3 |
sonicbluesky
referenced
this pull request
Jan 21, 2025
use correction suggested by andiling, and implemented over on suncalc3 by Hypnos3
zedxxx
added a commit
to sasgis/sas.planet.src
that referenced
this pull request
Jan 22, 2025
- Wrong azimuth angle: mourner/suncalc#6 - Nadir shifted from past to future: mourner/suncalc#125 - Coefficient is incorrect in solarTransitJ() function: mourner/suncalc#178
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nadir shifted from past to future!