Avoid text split bug by using matchedText #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been ages till #5 was posted, but today I have faced exactly the same issue. It seems that the
www.google.com
string is causing everything to break, astag.attrs.href
andtag.innerHtml
aren't good matchers for this case.I have tested it with such long text and without the changes it was rendered like on the first screenshot, on the second screenshot version after fix:
(The last example with
mailto
is my presentation mistake, it's correctly rendered after removing additionalmailto:
text)