Refactor JWT Class into JWTDecoder and JWTSigner, Improve Type Safety and Test Coverage #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant architectural improvements to the
JWT
implementation, enhancing clarity, separation of concerns, and test robustness. The monolithicJWT
class is split into two distinct classes:JWTDecoder
andJWTSigner
, each tailored for their specific responsibilities. Additionally, tests have been streamlined, parameterized, and modernized for better coverage and maintainability.Key Changes:
1. Refactor
JWT
ClassJWTDecoder
andJWTSigner
:JWTDecoder
: Handles JWT token decoding.JWTSigner
: Inherits fromJWTDecoder
, adds encoding functionality using a private key.@dataclass
for Immutability and Cleaner Initialization:dataclasses.field
to manage internal fields securely._date_to_timestamp
method duplication.date_to_timestamp
function.JWT
)JWTDecoder
orJWTSigner
based on the provided key type.2. Test Suite Enhancements:
mock.patch
usage.test_rsa_verify
andtest_rsa_verify_bad_key
now usepytest.mark.parametrize
for better coverage across different formats (jwk
,pem
,base64
).AttributeError
instead ofRuntimeError
,TypeError
instead ofValueError
).3. Minor Fixes and Improvements:
Backward Compatibility:
JWT
class structure.Testing: