Refactor HF checkpointer #1690
Merged
Refactor HF checkpointer #1690
+119
−203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…undry into milo/harbor-checkpointer
dakinggg
reviewed
Jan 24, 2025
dakinggg
reviewed
Jan 24, 2025
dakinggg
reviewed
Jan 25, 2025
dakinggg
reviewed
Jan 29, 2025
There was a problem hiding this comment.
The code looks right, but the test runs you linked I think don't use it? They appear to be an image with foundry main installed, without specifying a commit/branch to install over that. In particular, the peft checkpoint in the linked run doesn't have a "final_model_checkpoint" in the artifacts, as the non peft run does. I'd expect them to have the same file structure after this pr.
dakinggg
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the HF checkpointer to be more general.
Manual tests:
refactor-hf-checkpointer-peft-4xfWFZrefactor-hf-checkpointer-no-peft-nMFI4o