Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forward flag to subscribe/subscribe_update #743

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add forward flag to subscribe/subscribe_update #743

wants to merge 7 commits into from
+22 −0

Conversation

suhasHere
Copy link
Collaborator

@suhasHere suhasHere commented Feb 28, 2025 •
edited by afrind
Loading

Fixes: #372

@suhasHere suhasHere requested review from fluffy and wilaw February 28, 2025 05:15
@vasilvv
Copy link
Collaborator

vasilvv commented Feb 28, 2025

Since most of the time we do want to forward things, would this make more sense as a subscribe parameter?

@ianswett ianswett added the Subscribe Related to SUBSCRIBE message and subscription handling label Feb 28, 2025
fluffy
fluffy approved these changes Mar 1, 2025
View reviewed changes
Copy link
Contributor

@fluffy fluffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ianswett
ianswett reviewed Mar 1, 2025
View reviewed changes
Copy link
Collaborator

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LG. I suggested some text around explaining the functionality and how these subscriptions might be more likely to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianswett ianswett ianswett left review comments

@fluffy fluffy fluffy approved these changes

@kixelated kixelated Awaiting requested review from kixelated kixelated is a code owner

@vasilvv vasilvv Awaiting requested review from vasilvv vasilvv is a code owner

@wilaw wilaw Awaiting requested review from wilaw

Assignees
No one assigned
Labels
Subscribe Related to SUBSCRIBE message and subscription handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create an ability to pre-warm a track
4 participants
@suhasHere @vasilvv @fluffy @ianswett