Clarify use of NORMAL object status #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's implicit unless the object is zero-length Fixes: #682
afrind
requested review from
kixelated,
suhasHere,
vasilvv and
ianswett
as code owners
suhasHere
approved these changes
Feb 27, 2025
ianswett
reviewed
Feb 28, 2025
| @@ -2363,7 +2363,8 @@ are beyond the end of a group or track. | |||
|
|
|||
| `Status` can have following values: | |||
|
|
|||
| * 0x0 := Normal object. The payload is array of bytes and can be empty. | |||
| * 0x0 := Normal object. This status is implicit for any non-zero length object. | |||
| Zero-length objects explicitly encode the Normal status. | |||
There was a problem hiding this comment.
I agree the old description was not ideal, but I'm unsure what you're trying to say here?
I'd like to remove the use of 'Normal', because we're just talking about Objects. There aren't normal and non-normal Objects
There was a problem hiding this comment.
See the #682 that describes the problem. Basically, WTF is Normal for?
If we eliminate zero-length objects, we can get rid of this code point. But that's a separate issue. This just describes the current draft usage.
If you want to change the name of Normal - I don't love it either but don't have a better suggestion right now.
There was a problem hiding this comment.
SG, I think Normal is an odd word in this case, but it's good enough for now.
ianswett
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's implicit unless the object is zero-length
Fixes: #682