Close #69: FMMultivalueLink inherits from OrderedCollection #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #66: Add more tests for collection API on Links
Gabriel-Darbord
deleted the
69-Make-FMMultivalueLink-inherit-OrderedCollection
branch
Gabriel-Darbord
added a commit
to moosetechnology/Famix
that referenced
this pull request
Jan 17, 2024
Gabriel-Darbord
added a commit
to moosetechnology/Famix
that referenced
this pull request
Jan 17, 2024
Remove broken methods since moosetechnology/Fame#70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66: Add more tests for the collection API on links.
This has been tested on Fame, Famix, Moose, Casino and Modest.
Everything seems to work fine with the way the API has been used so far.
Note, however, that extending OrderedCollection adds a lot of API to FMMultivalueLink, and not all of it has been tested.
For example,
addFirst:does not yet implement a hook to set the opposite and check for unicity.