Fix foreign assets migration #3190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B7-runtimenoteworthy
WASM runtime size check:Compared to target branchMoonbase runtime: 2420 KB (+4 KB) 🚨 Moonbeam runtime: 2400 KB (-8 KB) ✅ Moonriver runtime: 2400 KB (+16 KB) Compared to latest release (runtime-3500)Moonbase runtime: 2420 KB (+468 KB compared to latest release) 🚨 Moonbeam runtime: 2400 KB (+464 KB compared to latest release) Moonriver runtime: 2400 KB (+464 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master rq/fix-foreign-assets-migration +/- ##
===================================================================
- Coverage 74.52% 74.48% -0.04%
Files 380 380
+ Lines 96102 96168 +66
===================================================================
+ Hits 71611 71626 +15
+ Misses 24491 24542 +51
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes the foreign assets migration.
What is being fixed?
When migrating approvals, some calls require calling the contract with the
approval owner (a smart-contract in this case)origin, which is not allowed, only EOA can perform external calls. In the case of this migration this must be allowed.The mint fails because in some situations, the target address is the burn address (0x0000...). In this scenarios, the migration should skip the minting.
The gas limit provided when creating the erc-20 was not big enough.