Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easypost integrate #10

Open
wants to merge 6 commits into
base: monterail
Choose a base branch
from
Open

Easypost integrate #10

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
47437ea
Add Easypost integration
RubyDiver Sep 20, 2021
f6f919b
Add figaro and credentials
RubyDiver Sep 20, 2021
b87b808
Change figaro to rails credentials
RubyDiver Sep 21, 2021
9bf74bb
Little fixes
RubyDiver Sep 21, 2021
954103a
Fix credentials
RubyDiver Sep 21, 2021
79a4fa9
delete initializer/easypost
RubyDiver Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,9 @@ node_modules
/node_modules
yarn-debug.log*
.yarn-integrity
/yarn-error.log
/yarn-error.log
# Ignore application configuration
/config/application.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remove it since we don't want to use Figaro


/config/master.key
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master.key should be added to some safe place like 1password

/config/credentials.yml.enc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is encrypted and you like to store it in the repository!
https://blog.saeloun.com/2019/10/10/rails-6-adds-support-for-multi-environment-credentials.html

3 changes: 3 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ gem 'pg'
gem 'sass-rails'
# Use Uglifier as compressor for JavaScript assets
gem 'uglifier'
# Used for locating stores
gem 'geocoder', '~> 1.6', '>= 1.6.7'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not used in this PR!


gem 'mini_racer'

Expand Down Expand Up @@ -84,6 +86,7 @@ gem 'spree_i18n', '>= 5.0'
gem 'spree_multi_vendor', " ~> 2.2"
gem 'spree_dev_tools', require: false, group: %w[test development]
gem 'spree_multi_domain', github: 'spree-contrib/spree-multi-domain'
gem 'spree_easypost', github: 'RubyDiver/spree_easypost'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add the comment why we have used fork version here


# Sentry Client
gem 'sentry-raven'
Expand Down
Loading