Support npm 3+ #2006
Merged
Support npm 3+ #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdebost
force-pushed
the
feature/npm3
branch
3 times, most recently
from
0ef1468 to
c606787
Compare
Open
cdebost
requested review from
johnnykahalawai,
tejaede and
marchant
and removed request for
marchant,
johnnykahalawai and
tejaede
If they can't be loaded from the app package, they will be retried under mr (npm 2 / legacy bundling support).
I suspect this code only exists for historical reasons, but it seems totally unnecessary, as bluebird will already be cached in the registry and will not be loaded twice. The hardcoded bluebird path causes an extra 404 when loading the app with npm 3+.
|
Tested across multiple projects with the matching mr PR. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial application of #1928 which contains only changes needed for npm 3 support. #1928 its sister PRs in mr and mop introduced too many changes to review all at once.
See montagejs/mr#145 for details on how this impacts existing apps.