Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: update for sylius 2.0 #254

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

petitbx
Copy link

@petitbx petitbx commented Jan 18, 2025

No description provided.

@maximehuran
Copy link
Member

I made some test and you made an amazing job !

I see an issue that I was working on on my side, the form collections.
For example if you choose an Image collection element, the form is not loaded :

image

Form collections seems to be managed with Live component now, and not in JQuery like before.

@maximehuran
Copy link
Member

Another issue with Image element, the selected image is not displayed

image

Also in the form

image

@petitbx
Copy link
Author

petitbx commented Jan 19, 2025

Yes, I saw these problems.
I also have 2 others problems, first one is markdown to html, the filter doesn't work and the other one is, I inject jQuery manually with a script balise...
But I'm still working on this upgrade !

@maximehuran
Copy link
Member

We will work on these issues soon. We will update your pull request ☺️

Thank you for your work !

@petitbx petitbx marked this pull request as draft January 20, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants