Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid error Tagged grid filters needs to have "type" attributes #42

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Avoid error Tagged grid filters needs to have "type" attributes #42

merged 1 commit into from
Nov 22, 2024

Conversation

maximehuran
Copy link
Member

@maximehuran maximehuran commented Nov 22, 2024 •
edited
Loading

Correct issue with Sylius Grid 1.13

!!    Tagged grid filters needs to have "type" attributes or implements "Sylius\C
!!    omponent\Grid\Filtering\TypeAwareFilterInterface".

image

Filter works !

image

@madamebiz madamebiz added Status: needs review Needs review quick win Easy to pick, everybody will be happy. labels Nov 22, 2024
@maximehuran maximehuran merged commit 9369c68 into monsieurbiz:master Nov 22, 2024
10 checks passed
@maximehuran maximehuran deleted the feature/correct-filter-autoconfigure branch November 22, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delyriand delyriand delyriand approved these changes

@lanfisis lanfisis Awaiting requested review from lanfisis

Assignees
No one assigned
Labels
quick win Easy to pick, everybody will be happy. Status: needs review Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximehuran @delyriand @madamebiz