Print error rather than exit when encountering permission denied #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if we encountered a file we could not read for permission reasons, we'd exit immediately. This meant that you either had to stop and fix the permissions or tell pt to ignore the file. Now we print the error out which is similar to what grep does. Rather than using log.Printf which could have issues writing at the same time as printing the matches, this uses the same printer. It also adds a new colour code for errors so that they are more noticable when running with coloured output. This should resolve monochromegane#145.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if we encountered a file we could not read for permission
reasons, we'd exit immediately. This meant that you either had to stop
and fix the permissions or tell pt to ignore the file.
Now we print the error out which is similar to what grep does.
Rather than using log.Printf which could have issues writing at the same
time as printing the matches, this uses the same printer. It also adds a
new colour code for errors so that they are more noticable when running
with coloured output.
This should resolve #145.