This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this change is broken:
When
MessageWriter.Write(object)
is called, a variant should be written (see also the comment above the method). If the object is an array, a variant containing the array should be written. A array which is not in a variant can be written usingMessageWriter.Write(Type,object)
orMessageWriter.WriteArray(T)
.If the code somewhere calls
MessageWriter.Write(object)
when a plain array is needed, the caller should be fixed.Currently, this change breaks returning an array as a variant, e.g. for the following service:
Calling
GetVal
will disconnect the service: