Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-298521: Decouple IPA Metrics Collection Job from FOAS Release GH Workflow (fixes) #405

Merged
merged 35 commits into from
Feb 6, 2025

Conversation

yelizhenden-mdb
Copy link
Collaborator

@yelizhenden-mdb yelizhenden-mdb commented Feb 5, 2025

Proposed changes

Jira ticket: CLOUDP-298521

The issue arises from performing two checkouts in the workflow. When a second checkout is executed, it resets the current workspace, causing the previously checked-out files to be lost. To address this:

  1. First, checkout the dev branch and upload the OAS file as an artifact.
  2. Then, perform the second checkout to the main branch and download the artifact (OAS file) to continue working with it.

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Changes to Spectral

  • I have read the README file for Spectral Updates

Further comments

@yelizhenden-mdb yelizhenden-mdb marked this pull request as ready for review February 5, 2025 19:13
@yelizhenden-mdb yelizhenden-mdb requested a review from a team as a code owner February 5, 2025 19:13
Copy link
Member

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still reviewing. Looking to see why we need to do 2 checkouts

@wtrocki
Copy link
Member

wtrocki commented Feb 6, 2025

As alternative to checkout you can:

curl -O https://raw.githubusercontent.com/mongodb/openapi/refs/heads/main/tools/spectral/ipa/metrics/scripts/dataDump.js

@yelizhenden-mdb yelizhenden-mdb merged commit 82d24b8 into main Feb 6, 2025
11 checks passed
@yelizhenden-mdb yelizhenden-mdb deleted the CLOUDP-298521/fix-GH-workflow branch February 6, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants