MONGOID-5676 [Monkey Patch Removal] Remove Time#configured #5716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyshields
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MONGOID-5676
Time#configuredis a deprecated kernel Monkey Patch. It was originally created to toggle between Ruby's nativeTimefunctionality andActiveSupport::TimeWithZone.Since Mongoid 7.3-ish Mongoid went all-in on
ActiveSupport::TimeWithZone, and this hack was deprecated. It can be simply stripped out with no replacement.This change will now require that
Time.zonebe set in the application (or spec_helper, in our case) or an error will be thrown. This is fine--99.99% of Rails apps will have it set, and for the 0.01% that don't its much better to get errors than to accidentally use Ruby's kernel Time which has all sorts of issues.Overall progress is tracked here: http://tinyurl.com/mongoid-monkey. Refer to MONGOID-5660 for context.