MONGOID-5662 [Monkey Patch Removal] Remove Object#__to_inc__ #5709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the code in the two places it was used. The logic is covered by existing specs, so no new specs needed.
johnnyshields
changed the title
johnnyshields
changed the title
|
Closing this in favor of #5741 so that we deprecate the monkey-patched methods, instead of removing them. Thanks for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MONGOID-5662
Object#__to_inc__is a kernel monkey patch used only in the #inc and #mul atomic methods.This PR removes the monkey patch and inlines its code to the two places it is used. The logic is covered by existing specs, so no new specs needed.
Overall progress is tracked here: http://tinyurl.com/mongoid-monkey. Refer to MONGOID-5660 for context.