MONGOID-5671 [Monkey Patch Removal] Remove Object#blank_criteria? and Hash#__mongoid_unsatisfiable_criteria? #5700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eprecated and not used in code.) - Remove ``Hash#_mongoid_unsatisfiable_criteria?`` method is removed (was previously marked @api private) and move it to a private method of Referenced::HasMany::Enumerable.
johnnyshields
changed the title
johnnyshields
changed the title
this tests an implementation detail and not a behavior, which is fragile. I'm not even sure this is an implementation detail we want, and testing it specifically pours metaphorical concrete around it, making it that much harder to remove later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MONGOID-5671
This PR removes two related kernel monkey patch methods:
Object#blank_criteria?method entirely (was previously @deprecated and not used in code.)Hash#_mongoid_unsatisfiable_criteria?method (was previously marked @api private, name contains underscore) and move it to a private method of Referenced::HasMany::Enumerable.Similar to #5689, I have kept the specs for a previously public method which is now private. My reasoning is the same--the method is only used in one class, therefore should be private, and its better to keep the specs intact for future refactoring.Overall progress is tracked here: http://tinyurl.com/mongoid-monkey. Refer to MONGOID-5660 for context.