Wrap update in transaction

mongodb · Nov 10, 2023 · b3dd4a1 · b3dd4a1
1 parent a023a7c
commit b3dd4a1
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/lib/mongoid/persistable/updatable.rb b/lib/mongoid/persistable/updatable.rb
@@ -38,8 +38,16 @@ def update_attribute(name, value)
       #
       # @return [ true | false ] True if validation passed, false if not.
       def update(attributes = {})
-        assign_attributes(attributes)
-        save
+        self.class.with_session do |session|
+          session.with_transaction do
+            assign_attributes(attributes)
+            save.tap do |result|
+              session.abort_transaction unless result
+            end
+          end
+        end
+      rescue StandardError => e
+        false
       end
       alias :update_attributes :update
 

diff --git a/spec/integration/validations_spec.rb b/spec/integration/validations_spec.rb
@@ -16,7 +16,8 @@
       end
 
       it 'does not persist the changes' do
-        expect { client.update!(companies: []) rescue nil }.not_to change { client.reload.companies }
+        client.update!(companies: []) rescue nil
+        expect(client.reload.companies).not_to be_empty
       end
     end
   end
@@ -32,7 +33,8 @@
       end
 
       it 'does not persist the changes' do
-        expect { building.update!(apartments: []) rescue nil }.not_to change { building.reload.apartments }
+        building.update!(apartments: []) rescue nil
+        expect(building.reload.apartments).not_to be_empty
       end
     end
   end