Change message ephemeral #20
Merged
+41
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichiki-mfw
commented
Jul 11, 2024
| with: | ||
| version: latest | ||
| args: release --snapshot --skip-publish --rm-dist --debug | ||
| args: release --snapshot --skip=publish --clean --verbose |
There was a problem hiding this comment.
There are several deprecated options
https://goreleaser.com/cmd/goreleaser_release/
ichiki-mfw
commented
Jul 11, 2024
| @@ -1,3 +1,4 @@ | |||
| version: 2 | |||
There was a problem hiding this comment.
It's needed to avoid this error
https://github.com/moneyforward/auriga/actions/runs/9889651283/job/27316188732
ichiki-mfw
commented
Jul 11, 2024
| format_overrides: | ||
| - goos: windows | ||
| format: zip | ||
| - format: tar.gz |
There was a problem hiding this comment.
sho0126hiro
approved these changes
Jul 14, 2024
| @@ -62,6 +62,7 @@ func Test_slackResponseService_postEmailList(t *testing.T) { | |||
| emails []*model.SlackUserEmail | |||
| cid string | |||
| ts string | |||
| user string | |||
There was a problem hiding this comment.
[IMO] I think the variable name of userID is better than user because the argument indicating this value of postEmailList is userID.
There was a problem hiding this comment.
Thank you. I'll fix it and merge this PR
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed all statements by Auriga to EphemeralMessage.
I considered refactoring as well, but since the differences would be significant, I decided to limit the changes to the above for now
https://moneyforward.slack.com/archives/C03CB6NF2G6/p1720156080683339