PT-850: Pending in Plugins for SW6 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaroslavzev
previously approved these changes
Jan 15, 2024
There was a problem hiding this comment.
utACK 👍
suggestion(non-blocking): from my prospective it would be nice to have place with conditions and it will help to maintain codebase in the future. This place can be hash, service object which contain mapping between transaction and responce statuses or humane readable method.
For example this two lines
$confirmResponseState != 'confirmed' &&
$confirmResponseState != 'pending'
can be moved to method with name orderConfirmed?
Please note that I am fine to leave as it's now.
|
@ivan-pugach-mondu @tikohov20 can it be deployed on our stage for testing? |
ivan-pugach-mondu
dismissed stale reviews from arthurmmoreira and Yaroslavzev
via
3ba18c2
I'll deploy it to the stage shop. |
tikohov20
suggested changes
Jan 16, 2024
|
Lets update the composer.json file this pr. |
tikohov20
previously approved these changes
Jan 17, 2024
ivan-pugach-mondu
requested review from
tikohov20,
Yaroslavzev and
arthurmmoreira
tikohov20
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to improve the order process and assign the proper status on the Shopware side when the payment goes through the pending flow
Release: p
Tickets: PT-850
Fixes # (issue)
https://mondu.atlassian.net/browse/PT-850
Checklist: