-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitted docs #6
Open
cheld
wants to merge
1
commit into
monasca:master
Choose a base branch
from
cheld:split-docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
## Creating the installer package | ||
|
||
### Metrics agent | ||
To use the latest version of monasca-agent, simply run | ||
``` | ||
./create_metrics_agent_installer.sh | ||
``` | ||
|
||
To use a specific version of monasca-agent, add the desired version number as an argument: | ||
``` | ||
./create_metrics_agent_installer.sh <version_number> | ||
``` | ||
|
||
Either way, this will generate a new executable named: `monasca-agent-<version_number>.run` . | ||
|
||
### Log agent | ||
To use default versions of `logstash` and `logstash_output_monasca_log_api`, simply run | ||
``` | ||
./create_log_agent_installer.sh | ||
``` | ||
You can add an argument to specify the `logstash` version, or two arguments to also specify the `logstash_output_monasca_log_api` version: | ||
``` | ||
./create_log_agent_installer.sh <logstash_version> <logstash_output_monasca_log_api_version> | ||
``` | ||
This will generate a new executable named: `log-agent-<logstash_version>_<logstash_output_monasca_log_api_version>.run` . | ||
|
||
### Monasca-ui plugin | ||
|
||
In order to create the monasca-ui installer, you need to run the | ||
following command: | ||
``` | ||
./create_monasca_ui_installer.sh <version_number> | ||
``` | ||
|
||
In case the `<version_number>` is omitted, the newest one will be used. | ||
|
||
## Releasing | ||
|
||
Rename the installer packages to match the OpenStack version, e.g.: | ||
|
||
``` | ||
metric-agent-pike.run | ||
log-agent-pike.run | ||
monasca-ui-pike.run | ||
``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, here: do you want to remove the user's ability to specify a logstash version at the time of creating the log-agent installer? Or do you just want to reduce the name of the .run file to not include the logstash version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to distinguish between user and developer. It is ok that a developer (you) to specify the logstash version. However, does it makes sense for users that search for a package on the releases page to include library version numbers into monasca artifact names? What happens if you fix the shell scritps and create a new download package? Do you keep the same version number? Sounds very strange to me.
To answer you question: in my understanding the version should be aligned with monasca version. How should a user know what to download in case the artifacts are not named cohesively ?
E.g. lets say you have installed Monasca version 'pike', than a user probably wants to download a package named pike as well