Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment Link Url Scope #759

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Payment Link Url Scope #759

merged 1 commit into from
Mar 25, 2024

Conversation

Sental
Copy link
Contributor

@Sental Sental commented Mar 7, 2024

Specify the Payment Link Url Scope to prevent the payment link url from using the admin url when different. Fixes issue: #758

Thank you for creating this pull request! To make the best use of your and our time we created this checklist to get the best possible pull requests:

  • The code is working on a plain Magento 2 installation.
  • The code follows the PSR-2 code style.
  • When an exception or error is logged the message is accompanied with some context, eg: Error when trying to get the payment status:
  • Contains tests for the changed/added code (great if so but not required).
  • I have added a scenario to test my changes.

This PR touches code in the following areas (Check what is applicable):

Frontend

  • Shopping cart
  • Checkout
  • Totals
  • Payment methods

Backend

  • Configuration
  • Order grid
  • Order view
  • Invoice view
  • Credit memo view
  • Shipment view
  • Email sending

Order Processing (Mollie communication)

  • Creating the order
  • Invoicing the order
  • Shipping the order
  • Refunding (credit memo) the order

Other
If you didn't check any boxes above, please describe your changes in this section.

Please describe the bug/feature/etc this PR contains:

Specify the scope for the payment link when it's created to prevent an incorrect link being generated.

Scenario to test this code:

Open the environment and...

Specify the Payment Link Url Scope to prevent the payment link url from using the admin url when different.
@Frank-Magmodules Frank-Magmodules self-assigned this Mar 11, 2024
@Marvin-Magmodules Marvin-Magmodules mentioned this pull request Mar 25, 2024
@Marvin-Magmodules Marvin-Magmodules merged commit 2c74bb9 into mollie:master Mar 25, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants