Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NULL gift wrapping amount case #751

Conversation

ImanuelBertrand
Copy link
Contributor

Fixes deprecation notice and subsequent crash in Adobe Commerce Cloud

Thank you for creating this pull request! To make the best use of your and our time we created this checklist to get the best possible pull requests:

  • The code is working on a plain Magento 2 installation.
  • The code follows the PSR-2 code style.
  • When an exception or error is logged the message is accompanied with some context, eg: Error when trying to get the payment status:
  • Contains tests for the changed/added code (great if so but not required).
  • I have added a scenario to test my changes.

This PR touches code in the following areas (Check what is applicable):

Frontend

  • Shopping cart
  • Checkout
  • Totals
  • Payment methods

Backend

  • Configuration
  • Order grid
  • Order view
  • Invoice view
  • Credit memo view
  • Shipment view
  • Email sending

Order Processing (Mollie communication)

  • Creating the order
  • Invoicing the order
  • Shipping the order
  • Refunding (credit memo) the order

Other
If you didn't check any boxes above, please describe your changes in this section.

Please describe the bug/feature/etc this PR contains:

When I tried to check out (in Adobe Commerce Cloud hosting), the process crashed with a deprecation notice.

Scenario to test this code:

Open the environment and check out without using gift wrapping.

Fixes deprecation notice and subsequent crash in Adobe Commerce Cloud
@Frank-Magmodules
Copy link
Collaborator

Hi There @ImanuelBertrand , Thank you for the Pull Request!
We'll review and test it, and once approved, we'll include it in the upcoming release.

@ryan-copeland
Copy link

@Frank-Magmodules We too are experiencing this same issue. Please can we look to get this merged.

@Frank-Magmodules
Copy link
Collaborator

Hello @ryan-copeland, we've previously discussed this PR on Slack, but it's good to bring it up publicly as well. Rest assured, we'll incorporate this PR into our review process and merge it once approved for the next release.

@ryan-copeland
Copy link

ryan-copeland commented Mar 8, 2024

Thanks @Frank-Magmodules ! Now get back to your sunbed and enjoy your holiday!😁

@Marvin-Magmodules Marvin-Magmodules mentioned this pull request Mar 25, 2024
@Marvin-Magmodules Marvin-Magmodules merged commit 0769f82 into mollie:master Mar 25, 2024
29 checks passed
@Frank-Magmodules
Copy link
Collaborator

Hi @ryan-copeland and @ImanuelBertrand , to formally close this PR, we'd like to confirm that we've incorporated it into our latest release. Thank you for your valuable contribution; it's greatly appreciated!

@ryan-copeland
Copy link

Thanks for the speedy turn around @Frank-Magmodules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants