BUGFIX async webhook fix #1026
Merged
BUGFIX async webhook fix #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MarijusCoding
commented
Jan 14, 2025
•
MarijusCoding
commented
| Questions | Answers |
|---|---|
| Branch? | release-6.2.6 |
| Description? | Fixed issue with latest mollie API changes that made webhook async. |
| Type? | bug fix |
| How to test? | Try checkouting with different statuses |
| Fixed issue ? | PIPRES-526 |
tomas862
suggested changes
Jan 15, 2025
controllers/front/return.php
Outdated
| @@ -103,7 +103,8 @@ public function initContent() | |||
| // any paid payments for this cart? | |||
|
|
|||
| if (false === $data['mollie_info']) { | |||
| $data['mollie_info'] = $paymentMethodRepo->getPaymentBy('order_id', (int) Order::getOrderByCartId($idCart)); | |||
| $orderId = (int) Order::getOrderByCartId($idCart); | |||
There was a problem hiding this comment.
does mollie support many PS versions ? If I not mistaken this static call in one version exists, in another, named differently. Can someone confirm or deny this ?
There was a problem hiding this comment.
Yeah, this method is deleted in PS 9 and we already have PR which replaces all those deprecated methods for PS 9 compatibility. Thank you, I replaced it with new one 🙏
controllers/front/return.php
Outdated
Comment on lines
107
to
109
| $data['mollie_info'] = $orderId != 0 ? $paymentMethodRepo->getPaymentBy('order_id', (int) $orderId) : []; | ||
| } | ||
| if (false === $data['mollie_info']) { |
There was a problem hiding this comment.
() $orderId, you already casted it once.
GytisZum
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.