[PIPRES-526] optimize and fix code

mollie · Jan 10, 2025 · 684f66a · 684f66a
1 parent 24adcd5
commit 684f66a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/controllers/front/return.php b/controllers/front/return.php
@@ -204,16 +204,19 @@ protected function processGetStatus()
 
         $transactionId = $dbPayment['transaction_id'] ?: Tools::getValue('transaction_id');
 
-        if (!isset($dbPayment) || !\Validate::isLoadedObject($cart = new Cart((int) Tools::getValue('cart_id')))) {
+        $cart = new Cart((int) $dbPayment['cart_id']);
+
+        if (!isset($dbPayment) || !Validate::isLoadedObject($cart)) {
             exit(json_encode([
                 'success' => false,
             ]));
         }
 
         /* @phpstan-ignore-next-line */
         $orderId = (int) Order::getOrderByCartId((int) $cart->id);
+
         /** @phpstan-ignore-line */
-        $order = new Order((int) $orderId);
+        $order = new Order($orderId);
 
         if ((int) $cart->id_customer !== (int) $this->context->customer->id) {
             exit(json_encode([