Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run issue in system service context #4653

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

connoratrug
Copy link
Contributor

@connoratrug connoratrug commented Jan 30, 2025

The default service passed params where port is expected warn and use default in case of NumberFormatException

What are the main changes you did

  • the service config passes an unexpected arg, causing the service to shutdown, this pr changes it ignore the param in case of error

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

Sorry, something went wrong.

The default service passed params where port is expected
warn and use default in case of NumberFormatException
@connoratrug connoratrug merged commit 19f80dc into master Jan 30, 2025
6 of 7 checks passed
@connoratrug connoratrug deleted the fix/run-issue-in-system-service-context branch January 30, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant