-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(directory): don't select more than 50 ontology items #4622
fix(directory): don't select more than 50 ontology items #4622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to only put this limitation only on 'Match all' queries, since the current implementation limits queries for any diagnosis in a certain block in ICD-10, which would still be a useful query to do.
There also is an inconsistency in how things work. If I select an entire block but that is more than fifty terms the user interface still shows the entire block as selected, but if I open the block I see that only part of them are selected. This leads to people thinking that they still searched the entire block. I think it is useful to make it visible in some way that not all of that block was selected next to the message at the top. At least it should only have the partial selection (-) symbol instead of the full selection (✓)
please add an regression test |
Quality Gate passedIssues Measures |
fixes: #906
What are the main changes you did
Todo
How to test
Checklist