Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tailwind): first version of RefInput to show REF as radiogroup and REF_ARRAY as checkboxgroup #4585
feat(tailwind): first version of RefInput to show REF as radiogroup and REF_ARRAY as checkboxgroup #4585
Changes from 18 commits
84e9a91
044f2bd
28b3099
fdd5d66
4239df7
1558770
43e3c99
c0a938d
1c55a8b
80006a6
4985c14
d67fce7
8a9b5d3
0def84f
8b457ac
cd398ed
9cd806d
936dbf9
3928c0b
10f278a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no way tailwind takes care of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think it's possible to add them to css/tailwind files. We would also need to refactor this component as there a lot of the javascript could be replaced by simpler tw classes. It would be good to do it in the next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave it for now and fix in another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how to call this component? And I notice the css doesn't work on all themes properly. Need help there.