Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix trigger params #3430

Merged
merged 1 commit into from
Feb 23, 2024
Merged

build: fix trigger params #3430

merged 1 commit into from
Feb 23, 2024

Conversation

connoratrug
Copy link
Contributor

@connoratrug connoratrug commented Feb 22, 2024 •
edited
Loading

all passed params are required to be listed, used or not
how to test:

  • explain here what to do to test this (or point to unit tests)

todo:

  • updated docs in case of new feature
  • added tests

@connoratrug connoratrug requested a review from mswertz February 22, 2024 16:36
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@connoratrug connoratrug merged commit 0eb5e09 into master Feb 23, 2024
5 checks passed
@connoratrug connoratrug deleted the build/fix-trigger-params branch February 23, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswertz mswertz mswertz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connoratrug @mswertz