Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: an instance of Pet should refer back to the collection of pets with qb:dataSet and not qb:DataSet #2961

Conversation

esthervanenckevort
Copy link
Member

  • test case for verify that the qb:dataSet predicate is used
  • use IRI_DATASET_CLASS and IRI_DATASET_PREDICATE to distinguish between the class and the predicate
  • fix the rowsToRdf method to use the IRI_DATASET_PREDICATE

Closes #2931

…ith qb:dataSet and not qb:DataSet

- test case for verify that the qb:dataSet predicate is used
- use IRI_DATASET_CLASS and IRI_DATASET_PREDICATE to distinguish between the class and the predicate
- fix the rowsToRdf method to use the IRI_DATASET_PREDICATE
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, untested.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@esthervanenckevort esthervanenckevort merged commit 6182fd8 into master Nov 10, 2023
@esthervanenckevort esthervanenckevort deleted the fix/2931-incorrect-use-of-qbdataset-class-where-qbdataset-property-is-meant branch November 10, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect use of qb:DataSet (Class) where qb:dataSet (Property) is meant
2 participants