Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect use of qb:DataSet (Class) where qb:dataSet (Property) is meant #2931

Closed
esthervanenckevort opened this issue Nov 8, 2023 · 0 comments · Fixed by #2961
Closed
Assignees
Labels

Comments

@esthervanenckevort
Copy link
Member

Describe the bug
We are using qb:DataSet as a predicate, while this should be qb:dataSet (notice lowercase d).

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://emx2.dev.molgenis.org/catalogue_demo/api/rdf/Datasets'
  2. Search for 'qb:DataSet'

Expected behavior
We use qb:DataSet to refer back from an item in the dataset to the dataset as a whole. The thing that we refer to with qb:dataSet is an instance of qb:DataSet.

Actual Result

Catalogue_demo:Datasets a owl:Class;
  rdfs:subClassOf qb:DataSet, sio:SIO_000754, owl:Thing;
  rdfs:label "Datasets";
  dcterms:description "Definition of a dataset within a (common) data model"@en .

<https://emx2.dev.molgenis.org:443/catalogue_demo/api/rdf/Datasets?resource=ANAGRAFICA&name=ANAGRAFICA>
  a Catalogue_demo:Datasets, sio:SIO_001187, qb:Observation;
  qb:DataSet Catalogue_demo:Datasets;
  <https://emx2.dev.molgenis.org:443/catalogue_demo/api/rdf/Datasets/column/resource>
    <https://emx2.dev.molgenis.org:443/catalogue_demo/api/rdf/ExtendedResources/ANAGRAFICA>;
  <https://emx2.dev.molgenis.org:443/catalogue_demo/api/rdf/Datasets/column/name> "ANAGRAFICA";
  <https://emx2.dev.molgenis.org:443/catalogue_demo/api/rdf/Datasets/column/sinceVersion>
    "1.0" .
@esthervanenckevort esthervanenckevort self-assigned this Nov 8, 2023
esthervanenckevort added a commit that referenced this issue Nov 10, 2023
…ith qb:dataSet and not qb:DataSet (#2961)

- test case for verify that the qb:dataSet predicate is used
- use IRI_DATASET_CLASS and IRI_DATASET_PREDICATE to distinguish between the class and the predicate
- fix the rowsToRdf method to use the IRI_DATASET_PREDICATE
closes #2931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant