Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pan5261 #380

Merged
merged 5 commits into from
Mar 7, 2025
Merged

Pan5261 #380

merged 5 commits into from
Mar 7, 2025

Conversation

natashapinto
Copy link
Collaborator

@natashapinto natashapinto commented Mar 6, 2025

This change is Reviewable

@rebeccahaines1 rebeccahaines1 self-assigned this Mar 7, 2025
Copy link
Contributor

@rebeccahaines1 rebeccahaines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 4 of 4 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @natashapinto)


Bedmaker/Pan5261/Pan5261_Logfile.md line 6 at r3 (raw file):

# Request form for R237
Pan5261_R227_bedrequest.txt was used  (added into mokabed/LiveBedfiles/RequestForms)

should be R237

Copy link
Contributor

@rebeccahaines1 rebeccahaines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small logfile change

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @natashapinto)

Copy link
Collaborator Author

@natashapinto natashapinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rebeccahaines1)


Bedmaker/Pan5261/Pan5261_Logfile.md line 6 at r3 (raw file):

Previously, rebeccahaines1 wrote…

should be R237

Done.

Copy link
Contributor

@rebeccahaines1 rebeccahaines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @natashapinto)

Copy link
Contributor

@rebeccahaines1 rebeccahaines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @natashapinto)

@rebeccahaines1 rebeccahaines1 merged commit 522dece into master Mar 7, 2025
2 checks passed
@rebeccahaines1 rebeccahaines1 deleted the Pan5261 branch March 7, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants