Add support for pomFile parameter
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be ok to review now. The only question I had would be whether or not I should update the README accordingly also. 🤷 |
Documentation on new parameter is enough, we not need update readme. |
slawekjaranowski
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The value of
mavenProject.getFile()may be referencing a file which has been altered (for example when using the flatten maven plugin) depending on when it's invoked.The idea of this MR is to allow the explicit specification of the POM file to format (or check) by making it possible to pass a custom value to
pomFile.Would allow to fix #72 (by making it explicit about the pom and not the "potentially altered file")