Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added jws header improvement #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added jws header improvement #20

wants to merge 1 commit into from

Conversation

kyaw-soe-tw
Copy link
Contributor

No description provided.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

pedrosousabarreto
pedrosousabarreto reviewed Mar 8, 2024
View reviewed changes
Copy link
Contributor

@pedrosousabarreto pedrosousabarreto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming _sendErrorFeedbackToFsp() is only called for errors generated by the switch this looks good.

Please confirm this is not used when we're passing-through error responses from other FSPs.
Also, make sure the TTK tests pass, because this was passing (which is indeed strange).

@kyaw-soe-tw
Copy link
Contributor Author

kyaw-soe-tw commented Mar 12, 2024 •
edited
Loading

@pedrosousabarreto , For all of the error case fspiop is using _sendErrorFeedbackToFsp method so jws signature will create all the case, would u like to create separate method when we're passing-through error responses from other FSPs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrosousabarreto pedrosousabarreto pedrosousabarreto left review comments

@ruirochawork ruirochawork Awaiting requested review from ruirochawork ruirochawork is a code owner

@koekiebox koekiebox Awaiting requested review from koekiebox koekiebox is a code owner

@tw-aungthawaye tw-aungthawaye Awaiting requested review from tw-aungthawaye tw-aungthawaye is a code owner

@myo-min-htet myo-min-htet Awaiting requested review from myo-min-htet myo-min-htet is a code owner

@ZweHMyat ZweHMyat Awaiting requested review from ZweHMyat ZweHMyat is a code owner

@SithuKyaw-Thitsaworks SithuKyaw-Thitsaworks Awaiting requested review from SithuKyaw-Thitsaworks SithuKyaw-Thitsaworks is a code owner

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k elnyry-sam-k is a code owner

@bushjames bushjames Awaiting requested review from bushjames bushjames is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyaw-soe-tw @pedrosousabarreto