Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added a helpful error message #208

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

clintonMF
Copy link
Contributor

Pull Request Template

Description

Currently running the dynamic endpoint without uploading files prior returns a 500 internal server error, This error message is not helpful to the user.

I used an exception to catch errors and return a more helpful message which tells the user to upload files before running the dynamic endpoint.

Fixes # #207

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

When you run the dynamic endpoint without uploading the files prior, the endpoint will return an error message telling you to do so.

image

...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

@clintonMF clintonMF changed the title refactor: added a helpful error message fix: Added a helpful error message Oct 30, 2022
@aornugent
Copy link
Contributor

@Palaksharma23 - this looks ok to merge, I think?

Copy link
Member

@Palaksharma23 Palaksharma23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aornugent, yes sir, we can merge it.
Thanks for working on it 🚀@clintonMF :)

@aornugent aornugent merged commit 3692589 into moja-global:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants