Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Type error in GCBM API causes (fatal) - main(306) - Value too large. error. #196

Closed
wants to merge 1 commit into from

Conversation

Freeman-kuch
Copy link

@Freeman-kuch Freeman-kuch commented Oct 15, 2022

Pull Request Template

Description

When /dynamic endpoint is visited during simulation, it raises Type error in GCBM API causes (fatal) - main(306) - Value too large. error with config files

Fixes #136

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I tested locally using Postman and added the necessary config files in GCBM_New_Demo_Run. The simulation did run and didn't raise further errors.

fix

...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

@Freeman-kuch Freeman-kuch changed the title Signed-off-by: freeman_kuch <[email protected]> fix: Type error in GCBM API causes (fatal) - main(306) - Value too large. error. #136 Oct 15, 2022
@Freeman-kuch Freeman-kuch changed the title fix: Type error in GCBM API causes (fatal) - main(306) - Value too large. error. #136 fix: Type error in GCBM API causes (fatal) - main(306) - Value too large. error. Oct 15, 2022
@Freeman-kuch Freeman-kuch deleted the main_306_fix branch October 15, 2022 22:14
@Freeman-kuch Freeman-kuch restored the main_306_fix branch October 15, 2022 22:29
@Freeman-kuch Freeman-kuch reopened this Oct 15, 2022
@Freeman-kuch Freeman-kuch deleted the main_306_fix branch October 15, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type error in GCBM API causes (fatal) - main(306) - Value too large. error.
1 participant