Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #55 unstable merge status bypass #56

Closed

Conversation

TheCoreMan
Copy link
Contributor

See #55 .

I tested it locally and it works. Can't post logs here (corporate repo) but tested with both modes.

image

I installed this locally with pipx, so I don't super care when y'all merge it, and if I missed something, please feel free to just edit the PR, it'll take me forever to get back to this.

Thanks for the tool!

Shay Nehmad

Sometimes you have broken actions that are not because of you. My
example is Vercel 😠 failing my PR just because I don't have
a user in some repo.

Anyways, here's a fix - added a commandline switch with the merge
mode. The default is "Clean" which is what you had before, so people
who already use the tool won't feel the difference.

Signed-off-by: Shay Nehmad <[email protected]>
While I'm here :)

Signed-off-by: Shay Nehmad <[email protected]>
@ZolotukhinM
Copy link
Collaborator

Thanks for the PR! I made some changes and landed it in two parts in #59 and #60 - for the new logic I decided to not introduce the new CL argument and simply update the default behavior. We can add the flag if someone specifically wants the old behavior.

@ZolotukhinM ZolotukhinM closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants