Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[simd] Simplify SIMD.reduce_op functions #3083

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[simd] Simplify SIMD.reduce_op functions #3083

wants to merge 1 commit into from
+50 −58

Conversation

soraros
Copy link
Contributor

@soraros soraros commented Jun 20, 2024 •
edited
Loading

  • Simplify the signature of reduce since it's doesn't have to be generic over type
  • Introduced a reduce overload for non-capturing functions
  • Simplify SIMD.reduce_op functions using SIMD.op methods directly

@soraros soraros force-pushed the simplify-simd-reduce branch from 2f1efe7 to 33ff9e2 Compare June 20, 2024 00:38
@soraros soraros marked this pull request as ready for review June 20, 2024 00:38
@soraros soraros requested a review from a team as a code owner June 20, 2024 00:38
JoeLoser
JoeLoser approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@JoeLoser JoeLoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@JoeLoser
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Jun 20, 2024
@JoeLoser
Copy link
Collaborator

This is hitting some compiler errors internally that we'll need to look into FYI

@soraros soraros force-pushed the simplify-simd-reduce branch from 33ff9e2 to 28c723d Compare July 11, 2024 20:04
@soraros soraros force-pushed the simplify-simd-reduce branch from 28c723d to 963d261 Compare July 30, 2024 21:18
@soraros soraros requested a review from JoeLoser July 30, 2024 21:23
@soraros soraros force-pushed the simplify-simd-reduce branch 2 times, most recently from 9f6bd52 to 3130ff5 Compare August 25, 2024 02:32
@JoeLoser JoeLoser force-pushed the simplify-simd-reduce branch from 3130ff5 to 461a82a Compare August 26, 2024 17:12
@JoeLoser
Copy link
Collaborator

!sync

@soraros @JoeLoser
[stdlib] Simplify SIMD.reduce_op functions
1c0d993 
- Introduced a new `reduce` overload for non-capturing functions
- Simplify `SIMD.reduce_op` functions using `SIMD.op` methods directly

Signed-off-by: Yiwu Chen <[email protected]>
@JoeLoser JoeLoser force-pushed the simplify-simd-reduce branch from 461a82a to 1c0d993 Compare August 26, 2024 18:55
@JoeLoser
Copy link
Collaborator

!sync

@skongum02 skongum02 deleted the branch modular:main January 29, 2025 18:58
@skongum02 skongum02 closed this Jan 29, 2025
@skongum02 skongum02 reopened this Jan 29, 2025
@skongum02 skongum02 changed the base branch from nightly to main January 29, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeLoser JoeLoser Awaiting requested review from JoeLoser

Assignees

@JoeLoser JoeLoser

Labels
imported-internally Signals that a given pull request has been imported internally.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soraros @JoeLoser @skongum02 @modularbot