Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[recipes] Update NuMojo to v0.5 #66

Merged
merged 5 commits into from
Feb 7, 2025
Merged

Conversation

forFudan
Copy link
Contributor

@forFudan forFudan commented Feb 5, 2025

This PR updates NuMojo to v0.5.

@forFudan forFudan marked this pull request as draft February 5, 2025 10:57
@forFudan forFudan changed the title Update numojo to v0.5 [recipes] Update NuMojo to v0.5 Feb 5, 2025
@forFudan
Copy link
Contributor Author

forFudan commented Feb 5, 2025

@shivasankarka, I made a PR on update of numojo to v0.5.

@forFudan forFudan marked this pull request as ready for review February 6, 2025 13:26
@carolinefrasca
Copy link
Collaborator

@forFudan here's the error we're seeing:

$SRC_DIR/tests.mojo:3:20: error: package 'numojo' does not contain 'mat'
 │ │ │ from numojo import mat
 │ │ │                    ^
 │ │ │ mojo: error: failed to parse the provided Mojo source module
 │ │ │ × error Script failed with status 1
 │ │ │ × error Work directory: '/home/runner/work/modular-community/modular-community/output/bld/rattler-build_numojo_1738881070/work/test/run/etc/conda/test-files/numojo/0'

@forFudan
Copy link
Contributor Author

forFudan commented Feb 6, 2025

@carolinefrasca, thanks! I forgot to remove this from the import. Now it should work.

@carolinefrasca carolinefrasca merged commit 6ebbd38 into modular:main Feb 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants