Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update artifact.js #50

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update artifact.js #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06e7795
Fix reviewdog permissions
modos189 Aug 13, 2024
e28d47c
Merge pull request #49 from modos189/fix/reviewdog-permissions
modos189 Aug 13, 2024
c7baaa4
Update artifact.js
modos189 Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/reviewdog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ jobs:
eslint:
name: runner / eslint
runs-on: ubuntu-latest
permissions:
checks: write
contents: read
pull-requests: read
steps:
- uses: actions/checkout@v2
- uses: reviewdog/action-eslint@v1
Expand Down
10 changes: 4 additions & 6 deletions core/code/artifact.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ window.artifact.processResult = function (portals) {
if (!artifact.portalInfo[guid]) artifact.portalInfo[guid] = {};

// store the decoded data - needed for lat/lng for layer markers
artifact.portalInfo[guid]._data = data;
artifact.portalInfo[guid]._data = data;

for(var type in data.artifactBrief.target) {
if (!artifact.artifactTypes[type]) artifact.artifactTypes[type] = {};
Expand All @@ -175,11 +175,9 @@ window.artifact.processResult = function (portals) {


// let's pre-generate the entities needed to render the map - array of [guid, timestamp, ent_array]
artifact.entities.push ( [guid, data.timestamp, ent] );
artifact.entities.push ( [guid, data.timestamp, ent] );

}

}
}}

/**
* Returns the types of artifacts currently known.
Expand Down Expand Up @@ -282,7 +280,7 @@ window.artifact.updateLayer = function() {

artifact._layer.addLayer(marker);

} else if (data[type].fragments) {
} else if ( data[type].fragments) {
// fragment(s) at portal

var iconUrl = '//commondatastorage.googleapis.com/ingress.com/img/map_icons/marker_images/'+type+'_shard.png'
Expand Down
Loading