Example of ESLint error messages #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // add a new div to the bottom of the sidebar and style it | ||
| $('#sidebar').append('<div id="available_ap_display"></div>'); | ||
| $('#available_ap_display').css({'color':'#ffce00', 'font-size':'90%', 'padding':'4px 2px'}); | ||
| // add a new div to the bottom of the sidebar and style it |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ··
Suggested change
| // add a new div to the bottom of the sidebar and style it | |
| // add a new div to the bottom of the sidebar and style it |
| $('#sidebar').append('<div id="available_ap_display"></div>'); | ||
| $('#available_ap_display').css({'color':'#ffce00', 'font-size':'90%', 'padding':'4px 2px'}); | ||
| // add a new div to the bottom of the sidebar and style it | ||
| $('#sidebar').append('<div id="available_ap_display"></div>'); |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ··
Suggested change
| $('#sidebar').append('<div id="available_ap_display"></div>'); | |
| $('#sidebar').append('<div id="available_ap_display"></div>'); |
| $('#available_ap_display').css({'color':'#ffce00', 'font-size':'90%', 'padding':'4px 2px'}); | ||
| // add a new div to the bottom of the sidebar and style it | ||
| $('#sidebar').append('<div id="available_ap_display"></div>'); | ||
| $('#available_ap_display').css({'color':'#ffce00', 'font-size':'90%', 'padding':'4px 2px'}); |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace $('#available_ap_display').css({'color':'#ffce00',·'font-size':'90%',·'padding':'4px·2px' with ··$('#available_ap_display').css({·color:·'#ffce00',·'font-size':·'90%',·padding:·'4px·2px'·
Suggested change
| $('#available_ap_display').css({'color':'#ffce00', 'font-size':'90%', 'padding':'4px 2px'}); | |
| $('#available_ap_display').css({ color: '#ffce00', 'font-size': '90%', padding: '4px 2px' }); |
| @@ -22,7 +22,7 @@ window.plugin.compAPStats.setupCallback = function() { | |||
|
|
|||
| } | |||
|
|
|||
| window.plugin.compAPStats.mapDataRefreshEnd = function() { | |||
| window.plugin.compAPStats.mapDataRefreshEnd =function() { | |||
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace function with ·function·
Suggested change
| window.plugin.compAPStats.mapDataRefreshEnd =function() { | |
| window.plugin.compAPStats.mapDataRefreshEnd = function () { |
| @@ -41,8 +41,8 @@ window.plugin.compAPStats.requestFinished = function() { | |||
| } | |||
| } | |||
|
|
|||
| window.plugin.compAPStats.updateNoPortals = function (hasFinished) { | |||
| $('#available_ap_display').html('Available AP in this area: ' | |||
| window.plugin.compAPStats.updateNoPortals = function (hasFinished ) { | |||
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'hasFinished' is defined but never used.
| @@ -41,8 +41,8 @@ window.plugin.compAPStats.requestFinished = function() { | |||
| } | |||
| } | |||
|
|
|||
| window.plugin.compAPStats.updateNoPortals = function (hasFinished) { | |||
| $('#available_ap_display').html('Available AP in this area: ' | |||
| window.plugin.compAPStats.updateNoPortals = function (hasFinished ) { | |||
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
Suggested change
| window.plugin.compAPStats.updateNoPortals = function (hasFinished ) { | |
| window.plugin.compAPStats.updateNoPortals = function (hasFinished) { |
Comment on lines
+45
to
46
| $('#available_ap_display').html( 'Available AP in this area: ' | ||
| + '<div style="color:red">Zoom closer to get all portals loaded.<div>'); |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·'Available·AP·in·this·area:·'⏎··· with 'Available·AP·in·this·area:·'
Suggested change
| $('#available_ap_display').html( 'Available AP in this area: ' | |
| + '<div style="color:red">Zoom closer to get all portals loaded.<div>'); | |
| $('#available_ap_display').html('Available AP in this area: ' + '<div style="color:red">Zoom closer to get all portals loaded.<div>'); |
🤖 Pull request artifacts
|
modos189
force-pushed
the
master
branch
11 times, most recently
from
4159d43 to
c55c7e1
Compare
modos189
force-pushed
the
master
branch
9 times, most recently
from
5da95d4 to
ccd8bd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.