-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR-#7427: Require query compilers to expose engine and storage format. #7430
Merged
sfc-gh-mvashishtha
merged 7 commits into
modin-project:main
from
sfc-gh-mvashishtha:7427/refactor/track-engine-and-storage-format-at-dataframe-and-series-level
Jan 31, 2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uery compiler level. Signed-off-by: sfc-gh-mvashishtha <[email protected]>
sfc-gh-mvashishtha
changed the title
REFACTOR-#7427: Track engine and storage format at the query compiler…
REFACTOR-#7427: Track engine and storage format in the query compiler.
Jan 28, 2025
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
sfc-gh-mvashishtha
changed the title
REFACTOR-#7427: Track engine and storage format in the query compiler.
REFACTOR-#7427: Require query compilers to expose engine and storage format.
Jan 28, 2025
… correcct execution Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
sfc-gh-mvashishtha
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
anmyachev,
dchigarev and
a team
as code owners
January 29, 2025 01:07
sfc-gh-jkew
reviewed
Jan 29, 2025
@anmyachev want to take a look? |
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
FYI black is broken: #7431 I will fix it. |
anmyachev
previously approved these changes
Jan 30, 2025
Co-authored-by: Anatoly Myachev <[email protected]>
Co-authored-by: Jonathan Shi <[email protected]>
anmyachev
approved these changes
Jan 31, 2025
sfc-gh-joshi
approved these changes
Jan 31, 2025
sfc-gh-jkew
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
engine
andstorage_format
required read-only properties for query compiler. We trackengine
andstorage_format
as follows:TestQc
is always onengine="Base",storage_format="Python"
PandasQueryCompiler
gets its engine and storage format from its_modin_frame
.NativeQueryCompiler
is always onengine="Base",storage_format="Native"
.For testing, this commit adds a step to
eval_general
that checks that ifoperation
takes a dataframe or series as its first input and produces a dataframe or series output, then it preservesengine
andstorage_format
. We can disable this step in rare cases where the engine changes in erroneous or unpredictable ways. Also, this commit adds a step toeval_io
that checks that newly created dataframes and series have an engine and storage format that match the defaultEngine
andStorageFormat
.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date