Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR-#7427: Require query compilers to expose engine and storage format. #7430

Conversation

sfc-gh-mvashishtha
Copy link
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha commented Jan 28, 2025

Make engine and storage_format required read-only properties for query compiler. We track engine and storage_format as follows:

  • TestQc is always on engine="Base",storage_format="Python"
  • PandasQueryCompiler gets its engine and storage format from its _modin_frame.
  • NativeQueryCompiler is always on engine="Base",storage_format="Native".

For testing, this commit adds a step to eval_general that checks that if operation takes a dataframe or series as its first input and produces a dataframe or series output, then it preserves engine and storage_format. We can disable this step in rare cases where the engine changes in erroneous or unpredictable ways. Also, this commit adds a step to eval_io that checks that newly created dataframes and series have an engine and storage format that match the default Engine and StorageFormat.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Track engine and storage format at dataframe & series level #7427
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

…uery compiler level.

Signed-off-by: sfc-gh-mvashishtha <[email protected]>
@sfc-gh-mvashishtha sfc-gh-mvashishtha changed the title REFACTOR-#7427: Track engine and storage format at the query compiler… REFACTOR-#7427: Track engine and storage format in the query compiler. Jan 28, 2025
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
@sfc-gh-mvashishtha sfc-gh-mvashishtha changed the title REFACTOR-#7427: Track engine and storage format in the query compiler. REFACTOR-#7427: Require query compilers to expose engine and storage format. Jan 28, 2025
… correcct execution

Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
@sfc-gh-mvashishtha
Copy link
Contributor Author

@anmyachev want to take a look?

Signed-off-by: sfc-gh-mvashishtha <[email protected]>
@sfc-gh-mvashishtha
Copy link
Contributor Author

FYI black is broken: #7431

I will fix it.

anmyachev
anmyachev previously approved these changes Jan 30, 2025
modin/tests/pandas/test_io.py Outdated Show resolved Hide resolved
@sfc-gh-mvashishtha sfc-gh-mvashishtha merged commit 35275e1 into modin-project:main Jan 31, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track engine and storage format at dataframe & series level
4 participants