FIX-#6822: Do not propagate NotImplementedError to a user on a 'set_columns()' with dupl labels #6823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r on a 'set_columns()' with dupl labels Signed-off-by: Dmitry Chigarev <[email protected]>
dchigarev
changed the title
Signed-off-by: Dmitry Chigarev <[email protected]>
dchigarev
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
anmyachev and
a team
as code owners
YarShev
approved these changes
Dec 13, 2023
anmyachev
reviewed
Dec 13, 2023
| @@ -294,6 +294,11 @@ def set_index( | |||
| Calling this method on a descriptor that returns ``None`` for ``.columns_order`` | |||
| will result into information lose. | |||
| """ | |||
| if len(new_index) != len(set(new_index)): | |||
There was a problem hiding this comment.
Would it be better to use method nunique?
There was a problem hiding this comment.
np.unique struggles to handle MultiIndex objects, that's the reason we use set() everywhere in this class
There was a problem hiding this comment.
new_index.unique() might also not always work as sometimes it can be a python list here
There was a problem hiding this comment.
new_index.unique()might also not always work as sometimes it can be a python list here
Should we update the docstring for that?
There was a problem hiding this comment.
yep, docstring seems to be incorrect, will update in some future PR
anmyachev
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
DtypesDescriptordescribes partially known dtypes and doesn't support duplicated column labels. Everywhere in the project, we wrap constructions of new descriptors withtry: ... catch NotImplementedError:in order to avoid propagating the error to a user in cases where dupl labels occur. This PR fixes a missed case when explicitly setting dupl labels via._set_columns().flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sNotImplementedErrorwhen trying to set duplicated column names #6822docs/development/architecture.rstis up-to-date