Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST-#6795: don't use platform-dependent int type #6796

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Dec 3, 2023

What do these changes do?

  • Depending on the platform int can be 32 bits or 64 bits.
  • These changes are enough for the tests to work on Windows. I don’t think it’s necessary to test at CI for now.
  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves pytest modin/test/storage_formats/pandas/test_internals.py failed when running on windows #6795
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev marked this pull request as ready for review December 3, 2023 22:03
@dchigarev
Copy link
Collaborator

dchigarev commented Dec 4, 2023

what's the problem with using the platform-dependent type here? wouldn't 'int' always resolve into 'int32' everywhere, so all the comparisons still stay true?

@anmyachev
Copy link
Collaborator Author

what's the problem with using the platform-dependent type here? wouldn't 'int' always resolve into 'int32' everywhere, so all the comparisons still stay true?

This is not the same type as what pandas uses by default (otherwise the tests would pass on windows and there would be no problem)

@dchigarev dchigarev merged commit 275e32b into modin-project:master Dec 4, 2023
37 checks passed
@anmyachev anmyachev deleted the issue6795 branch December 4, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest modin/test/storage_formats/pandas/test_internals.py failed when running on windows
2 participants