FIX-#6786: properly d2p for cross DataFrame.join
#6787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
commented
Nov 30, 2023
| @@ -1163,7 +1163,7 @@ def join( | |||
| if other.name is None: | |||
| raise ValueError("Other Series must have a name") | |||
| other = self.__constructor__(other) | |||
| if on is not None: | |||
| if on is not None or how == "cross": | |||
There was a problem hiding this comment.
After this branch there is an implementation using concat, but parameter how=='concat' is not exist for it (only for join and merge).
anmyachev
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
dchigarev and
a team
as code owners
3 tasks
YarShev
approved these changes
Dec 1, 2023
devendra1007
reviewed
Dec 1, 2023
| @@ -1163,7 +1163,7 @@ def join( | |||
| if other.name is None: | |||
| raise ValueError("Other Series must have a name") | |||
| other = self.__constructor__(other) | |||
| if on is not None: | |||
| if on is not None or how == "cross": | |||
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date