PERF-#6749: Preserve partial dtype for the result of 'reset_index()' #6751
+148
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set_index()' Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
dchigarev
force-pushed
the
issue_6749
branch
from
ae14ce3 to
ffb32cf
Compare
dchigarev
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
anmyachev and
a team
as code owners
anmyachev
reviewed
Nov 20, 2023
| try: | ||
| new_dtypes = ModinDtypes.concat([new_dtypes, self._dtypes]) | ||
| except NotImplementedError: | ||
| # can raise on duplicated labels |
There was a problem hiding this comment.
If the old procedure worked in this case, then it can still be used.
There was a problem hiding this comment.
@dchigarev can I merge it, or will you look at this?
There was a problem hiding this comment.
I'll look at this
There was a problem hiding this comment.
added the old logic to ModinDtypes.concat(), however, it's still worth keeping this try-except block here, since it still can raise a NotImplementedError
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| # test that 'ModinDtypes.concat' with duplicated labels raises when not all dtypes are materialized | ||
| with pytest.raises(NotImplementedError): | ||
| res = ModinDtypes.concat( |
Check notice
Code scanning / CodeQL
Unused local variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Preserve partial dtypes for the result of
.reset_index()by usingModinDtypes.concat()APIflake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -s.reset_index()#6749docs/development/architecture.rstis up-to-date