Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6732: Fix inferring result dtypes for binary operations #6737

Merged
merged 4 commits into from
Nov 16, 2023
Merged

FIX-#6732: Fix inferring result dtypes for binary operations #6737

merged 4 commits into from
Nov 16, 2023

Conversation

dchigarev
Copy link
Collaborator

What do these changes do?

Instead of using find_common_dtype that sometimes gives incorrect results, we now run a binary operation on small pandas DataFrames to get proper dtypes.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: __truediv__ between boolean and float has incorrect result type #6732
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 13, 2023
View reviewed changes
modin/core/dataframe/algebra/binary.py
dtypes = func(df1, df2).dtypes.set_axis(common_columns)
# it sometimes doesn't work correctly with strings, so falling back to
# the "common_cast" method in this case
except TypeError:

Check notice

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.
@dchigarev
skip failing HDK tests
312e4f6 
Signed-off-by: Dmitry Chigarev <[email protected]>
@dchigarev
fix isort
0bc6ac4 
Signed-off-by: Dmitry Chigarev <[email protected]>
@dchigarev dchigarev marked this pull request as ready for review November 13, 2023 14:36
@dchigarev dchigarev mentioned this pull request Nov 16, 2023
Merged
7 tasks
anmyachev
anmyachev approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@anmyachev anmyachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anmyachev anmyachev merged commit 1b36f4c into modin-project:master Nov 16, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmyachev anmyachev anmyachev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@YarShev YarShev Awaiting requested review from YarShev YarShev is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: __truediv__ between boolean and float has incorrect result type
2 participants
@dchigarev @anmyachev