Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix issues with the package-lock.json #2865

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bashmish
Copy link
Member

@bashmish bashmish commented Jan 22, 2025

We have the following issues with the dependencies:

npm error invalid: [email protected] /Users/***/Files/Projects/modernweb-dev/web/packages/test-runner-puppeteer/node_modules/puppeteer
npm error missing: @storybook/mdx1-csf@^0.0.1, required by @storybook/[email protected]
npm error invalid: @storybook/[email protected] /Users/***/Files/Projects/modernweb-dev/web/node_modules/@storybook/theming
npm error invalid: @storybook/[email protected] /Users/***/Files/Projects/modernweb-dev/web/node_modules/@storybook/client-logger

What I did

  1. Regenerated the lock file from scratch

Such issues are hard to fix individually, also I'm planning to update Storybook 7->8, which would cause a dramatical lock file update anyway, so I think this is acceptable solution.

Also we see now some new NPM deprecation warnings, which gives new insights and is good.

Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: c5579cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bashmish bashmish marked this pull request as draft January 22, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant